[buddypress-trac] [BuddyPress Trac] #5637: Use bp_activity_set_action() to fill bp-templates activity dropdowns
noreply at wordpress.org
Wed May 14 16:37:44 UTC 2014
#5637: Use bp_activity_set_action() to fill bp-templates activity dropdowns
Reporter: imath | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.1
Component: Activity | Version: 2.0
Severity: normal | Resolution:
Keywords: has-patch |
Comment (by imath):
Replying to [comment:1 boonebgorges]:
Updated the patch to 5367.02.diff
> 1. You are excluding types from the group members screen with a
blacklist. This is a bit messy. Maybe 'members' and 'group_members' could
be different scopes.
That's really better, thanks a lot for advice, i've created the
'members_groups' scope because it's in a member's profile groups tab
> 2. The labels you're using in each component don't seem to match the
values currently hardcoded into the templates. They probably should.
I've checked again, in previous version i forgot to add a domain, but i
don't find the wrong labels :( There are 3 labels, i've created as they
were not existing :
Activity comment => __( 'Update replies', 'buddypress' )
New Blog => __( 'Site creations', 'buddypress' )
Changed Avatar => __( 'Profile Picture Updates', 'buddypress' )
> 3. Strings should be escaped when building the `<option>` markup
Oops! Corrected this. Thanks.
> 4. What's the purpose of casting `$label` to an array and then doing a
`foreach()` loop on it? Is there ever more than one label?
I think around midnight i like to make my life harder! You're right, i've
changed this as anyway i need to loop in actions to get the different
> 5. Looks like we never include a `'new_blog'` filter. This is odd.
(Probably a subject for a separate enhancement ticket.)
Yes i guess so, we would only have to set the label & scopes ;)
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5637#comment:2>
BuddyPress Trac <http://buddypress.org/>
More information about the buddypress-trac