[buddypress-trac] [BuddyPress Trac] #5637: Use bp_activity_set_action() to fill bp-templates activity dropdowns

buddypress-trac noreply at wordpress.org
Wed May 14 13:43:15 UTC 2014

#5637: Use bp_activity_set_action() to fill bp-templates activity dropdowns
 Reporter:  imath        |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.1
Component:  Activity     |     Version:  2.0
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
Changes (by boonebgorges):

 * keywords:  has-patch 2nd-opinion => has-patch


 I like this idea. A couple thoughts:

 1. You are excluding types from the group members screen with a blacklist.
 This is a bit messy. Maybe 'members' and 'group_members' could be
 different scopes.
 2. The labels you're using in each component don't seem to match the
 values currently hardcoded into the templates. They probably should.
 3. Strings should be escaped when building the `<option>` markup
 4. What's the purpose of casting `$label` to an array and then doing a
 `foreach()` loop on it? Is there ever more than one label?
 5. Looks like we never include a `'new_blog'` filter. This is odd.
 (Probably a subject for a separate enhancement ticket.)

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5637#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list