[buddypress-trac] [BuddyPress Trac] #5637: Use bp_activity_set_action() to fill bp-templates activity dropdowns

buddypress-trac noreply at wordpress.org
Wed May 14 21:27:10 UTC 2014

#5637: Use bp_activity_set_action() to fill bp-templates activity dropdowns
 Reporter:  imath        |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.1
Component:  Activity     |     Version:  2.0
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |

Comment (by boonebgorges):

 In 5367.03.patch I make the following changes:

 - Call it 'context' instead of 'scopes'. I think this is clearer.
 - Change the wording of the newly introduced labels
 - Change the context names. 'group' and 'member' seem to be more accurate
 to me, since they're for use on single group/member pages
 - Instead of passing a context to `bp_get_activity_show_filters()` in the
 template, do some logic in that function itself to determine the proper
 context. This is more similar to what we do for other template functions
 (eg `bp_has_activities()`). It also avoids your ugly hack of adding
 `_groups` to the end of the context in some cases - all the logic is now
 centralized, but can be overridden by passing a value for `$context`.
 - Change the "special case" for friends - your technique was maybe
 unnecessarily abstract, and would any kinds of duplicates. Maybe we want
 to do this, but we should talk about it first.
 - Clean up code styling a bit

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5637#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list