[wp-trac] [WordPress Trac] #65317: Removal of HTML5 script theme support affects older theme gallery layout in frontend

[WordPress Trac]

#65317: Removal of HTML5 script theme support affects older theme gallery layout in
frontend
---------------------------+-----------------------
 Reporter:  Ov3rfly        |       Owner:  (none)
     Type:  defect (bug)   |      Status:  reopened
 Priority:  normal         |   Milestone:  7.1
Component:  Script Loader  |     Version:  7.0
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  docs
---------------------------+-----------------------
Changes (by sabernhardt):

 * keywords:  close has-patch => has-patch
 * focuses:   => docs
 * milestone:   => 7.1


Comment:

 The filters' documentation could use some editing. The summary for
 `gallery_style` did not mention the opening `div`, and a description can
 discourage using regular expressions to remove all CSS.

 > That directory search covers only the wordpress.org repository.

 Yes, there are plenty of themes outside the free repository, but the point
 is that the directory search only found the replace function with single
 quotes. If anything were worth reverting, it seems better to go back to
 the single quotes for the 16-plus themes we can identify. But then it
 would not help anyone with Renkon or another theme that uses double
 quotes.

 #15103 introduced the `use_default_gallery_style` filter because the
 "gallery_style filter should die"; it is not very reliable.

 > Most themes from major renowned producers like ElmaStudio Renkon

 @elmastudio
 [https://themes.trac.wordpress.org/browser/yoko/1.2.3/functions.php?marks=356#L356
 updated Yoko] with `use_default_gallery_style` in October 2018.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/65317#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform