[wp-trac] [WordPress Trac] #34913: Unscheduling cron jobs fails when original arguments were not an array.

[WordPress Trac]

#34913: Unscheduling cron jobs fails when original arguments were not an array.
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:
                                                 |  johnjamesjacoby
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.9
Component:  Cron API                             |     Version:  3.0
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests 2nd-        |     Focuses:
  opinion needs-dev-note                         |
-------------------------------------------------+-------------------------

Comment (by johnbillion):

 Some feedback on [attachment:"34913-6.9.diff"]:

 * The `_doing_it_wrong()` messages should include the associated cron
 event name, otherwise having a bunch of these messages in your error log
 won't be very actionable.
 * I think the `assertEquals` calls should use `assertSame` so we're not
 coercing types during a test that deals with types
 * Can we get this patch into a pull request so the test suite can run?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/34913#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform