[wp-trac] [WordPress Trac] #52886: Update esc_url to allow for specifying an https:// as default protocol

[WordPress Trac]

#52886: Update esc_url to allow for specifying an https:// as default protocol
-------------------------------------------------+-------------------------
 Reporter:  mkaz                                 |       Owner:  desrosj
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.9
Component:  Formatting                           |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests has-dev-    |     Focuses:
  note commit dev-reviewed                       |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  has-patch has-unit-tests has-dev-note dev-feedback => has-
     patch has-unit-tests has-dev-note commit dev-reviewed
 * owner:  SergeyBiryukov => desrosj
 * status:  reopened => assigned


Comment:

 Replying to [comment:28 wildworks]:
 > Just to confirm, should we update the PHPDoc for deprecated functions as
 well? If so, I think we may also need to update the PHPDoc for the
 `clean_url()` function.

 I went and looked through the `deprecated.php` file and I was unable to
 find any function with a `@since` parameter with a higher version than the
 one noted in the `@deprecated` tag.

 I don't think that `clean_url()`'s docblock should be updated because:
 - `_deprecated_function()` is called, which leaves a notice in the
 `debug.log` about relying on a deprecated function.
 - The `clean_url()` function does not break. It just means that the old
 behavior will persist (always using `http://` when the URL is missing a
 protocal).
 - We don't typically update the documentation for deprecated functions to
 reflect changes to the preferred ones.

 If there's something I'm missing and this is desired, I think this can be
 adjusted later. For now, [61273] looks good to backport so that the inline
 docs are updated for the 6.9 release.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52886#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform