[wp-trac] [WordPress Trac] #42598: Twenty Seventeen: Sticky header offset issue

[WordPress Trac]

#42598: Twenty Seventeen: Sticky header offset issue
-------------------------------------------+-----------------------------
 Reporter:  anevins                        |       Owner:  (none)
     Type:  defect (bug)                   |      Status:  assigned
 Priority:  normal                         |   Milestone:  Future Release
Component:  Bundled Theme                  |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  needs-patch changes-requested  |     Focuses:  javascript
-------------------------------------------+-----------------------------
Changes (by SirLouen):

 * keywords:  has-patch needs-testing => needs-patch changes-requested


Comment:

 == Patch Test Report
 === Description
 ❌ This report validates that the issue can be reproduced, but the
 indicated patch doesn't work as expected.

 Patch tested:
 https://core.trac.wordpress.org/attachment/ticket/42598/42598.2.diff

 === Environment
 - WordPress: 6.9-alpha-60093-src
 - PHP: 8.2.28
 - Server: nginx/1.27.5
 - Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
 - Browser: Chrome 136.0.0.0
 - OS: Windows 10/11
 - Theme: Twenty Seventeen 3.9
 - MU Plugins: None activated
 - Plugins:
   * Test Reports 1.2.0

 === Reproduction Steps
 1. Create enough content with posts so we can scroll down with ease
 2. Create a blog post and by the end, for example called Test with slug
 /test/ set and `id="about"`, so we can link anchor to it
 3. Create a Menu and set it to Top Menu
 4. Add a Custom link in the menu that links to the page and the anchor
 (for example `<your_url>/test#about`)
 5. Go to home page
 6. Click on the Custom link to About
 7. 🐞 The page doesn't adjust to the anchored title, there is a big gap in
 between

 Screencast with the example attached.

 === Actual Results
 1. ❌ Issue is not resolved with patch. Same gap appears after applying
 patch.

 === Additional Notes
 - The
 [https://core.trac.wordpress.org/attachment/ticket/42598/%2342598.patch
 last patch] doesn't add anything extra (only some PHPCS) plus it doesn't
 apply, so I simply tested with the previous patch.

 === Supplemental Artifacts
 Sample Screencast: https://streamable.com/tagaec

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42598#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform