[wp-trac] [WordPress Trac] #63187: Wrong Inconsistent Permissions Check in Filesystems

[WordPress Trac]

#63187: Wrong Inconsistent Permissions Check in Filesystems
-------------------------------------------------+-------------------------
 Reporter:  SirLouen                             |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.9
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  dev-feedback has-testing-info has-   |     Focuses:
  patch early                                    |
-------------------------------------------------+-------------------------

Comment (by siliconforks):

 Replying to [comment:5 SirLouen]:
 > But if it happens not to be deleted for whatever issue during the
 update, future updates will permanently fail

 This should not cause future updates to fail.  Before `update_core()` is
 called, the `unpack_package()` method is called:

 https://github.com/WordPress/wordpress-
 develop/blob/baab2b8f2273319817edede1b3360f212cf42241/src/wp-
 admin/includes/class-core-upgrader.php#L156
 https://github.com/WordPress/wordpress-
 develop/blob/baab2b8f2273319817edede1b3360f212cf42241/src/wp-
 admin/includes/class-core-upgrader.php#L178

 The `unpack_package()` method is supposed to delete everything in the
 `upgrade` directory:

 https://github.com/WordPress/wordpress-
 develop/blob/baab2b8f2273319817edede1b3360f212cf42241/src/wp-
 admin/includes/class-wp-upgrader.php#L367

 > On the other hand, overwriting that file is innocuous

 I don't think it's necessarily innocuous.  That file is not supposed to be
 there.  If that file is appearing there for some reason, I think it would
 be best to find the root cause of why that is happening instead of just
 overwriting it.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63187#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform