[wp-trac] [WordPress Trac] #63187: Wrong Inconsistent Permissions Check in Filesystems

[WordPress Trac]

#63187: Wrong Inconsistent Permissions Check in Filesystems
-------------------------------------------------+-------------------------
 Reporter:  SirLouen                             |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.9
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  dev-feedback has-testing-info has-   |     Focuses:
  patch early                                    |
-------------------------------------------------+-------------------------

Comment (by SirLouen):

 Replying to [comment:4 audrasjb]:
 > By the way, you're right when saying that the patch is super simple. I
 just feel concerned with introducing a change unrelated to 6.8 this late
 in the release cycle. I'll reconsider this during the next bug scrub so
 hopefully we can have more thoughts on this bugfix.

 @audrasjb a little more info about this:

 It's very rare that it's triggered because generally `version-current.php`
 should be deleted during any upgrade here:
 https://github.com/WordPress/wordpress-
 develop/blob/baab2b8f2273319817edede1b3360f212cf42241/src/wp-
 admin/includes/update-core.php#L1103-L1104

 But if it happens not to be deleted for whatever issue during the update,
 future updates will permanently fail, returning a weird error that is
 impossible to debug for the average user (Inconsistent permissions for a
 file that doesn't even correlate with the thing that is actually causing
 the error)

 On the other hand, overwriting that file is innocuous because it's part of
 the process. In fact, the error is provoked because technically the copy
 (and potentially an overwrite) function are failing (always failing
 because of the perma-false).

 TL;TR: A very edge case that could be potentially frustrating.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63187#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform