[wp-trac] [WordPress Trac] #33600: Add `theme_mods_{$stylesheet}` option during `populate_options()`

WordPress Trac noreply at wordpress.org
Wed Mar 19 15:30:01 UTC 2025


#33600: Add `theme_mods_{$stylesheet}` option during `populate_options()`
-------------------------+-----------------------------
 Reporter:  dlh          |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Future Release
Component:  Themes       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  close        |     Focuses:
-------------------------+-----------------------------
Changes (by SirLouen):

 * keywords:  has-patch has-unit-tests needs-testing-info => close


Comment:

 Replying to [comment:6 dlh]:
 > The problem occurs when `get_theme_mod()` is called before
 `set_theme_mod()` is, if it ever is.

 This is one topic I'm commenting lately in the core test group. Many
 patches are coming too theoretical without a real use case. And are
 sometimes so entangled, that as you say "if it ever is", can be,
 technically never or even, as I've seen in some patches, in a wrong coding
 scenario (not sure which is this case).

 > the change proposed in this ticket has little practical impact today,
 although I still think it's technically sound.
 So then we can say we can confirm to close this very old ticket, because
 it's not necessary anymore. If someone happens to locate an issue in the
 future, can just re-open the ticket.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/33600#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list