[wp-trac] [WordPress Trac] #61858: Background images: resolve ref and ensure appropriate default values

[WordPress Trac]

#61858: Background images: resolve ref and ensure appropriate default values
-------------------------------------------------+-------------------------
 Reporter:  ramonopoly                           |       Owner:  ramonopoly
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.7
Component:  Themes                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests gutenberg-  |     Focuses:
  merge                                          |
-------------------------------------------------+-------------------------

Comment (by ramonopoly):

 Thanks for the info @mukesh27

 I'm AFK for a week, but looking at the code and the
 [https://github.com/WordPress/performance/issues/1572#issuecomment-2387861711,
 report] I think we can avoid calling [https://github.com/WordPress
 /wordpress-develop/blob/trunk/src/wp-includes/class-wp-theme-
 json.php#L2704, WP_Theme_JSON::get_blocks_metadata], which seems to be the
 source of the regression.

 Instead of iterating over the output of
 `WP_Theme_JSON::get_styles_block_nodes()`, I think it's enough to iterate
 over `$incoming_data['styles']['blocks']` to check block styles for object
 values.

 I can look when I get back if there's no movement in between.

 cc @andrewserong for visibility.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61858#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform