[wp-trac] [WordPress Trac] #61858: Background images: resolve ref and ensure appropriate default values

[WordPress Trac]

#61858: Background images: resolve ref and ensure appropriate default values
-------------------------------------------------+-------------------------
 Reporter:  ramonopoly                           |       Owner:  ramonopoly
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.7
Component:  Themes                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests gutenberg-  |     Focuses:
  merge                                          |
-------------------------------------------------+-------------------------
Changes (by mukesh27):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Reopening as we found https://github.com/WordPress/wordpress-
 develop/blob/trunk/src/wp-includes/class-wp-theme-json.php#L3239-L3251 is
 too expensive see the profiling result. I removed the code and did the
 comparison.

 See
 https://github.com/WordPress/performance/issues/1572#issuecomment-2387861711
 for more information

 ### Server-timing for TT4 home/blog page

 || Mertic || Beta 1 || Beta 1 with remove code || Diff % || Diff abs. ||
 || Response Time || 252.84 || 247.12 || -2.26% || -5.72 ||
 || wp-before-template || 76.26 || 76.28 || 0.03% || 0.02 ||
 || wp-before-template-db-queries || 3.3 || 3.35 || 1.52% || 0.05 ||
 || wp-template || 173.42 || 167.66 || -3.32% || -5.76 ||
 || wp-total || 249.87 || 244.23 || -2.26% || -5.64 ||
 || wp-template-db-queries || 2.6 || 2.59 || -0.38% || -0.01||


 🔴 It clear shows that the code introduce **~3%** regression

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61858#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform