[wp-trac] [WordPress Trac] #61112: Avoid re-constructing `WP_Theme_JSON` object from raw theme_json, instead use `WP_Theme_JSON` object inside `WP_Theme_JSON_data`

WordPress Trac noreply at wordpress.org
Fri May 24 03:53:46 UTC 2024


#61112: Avoid re-constructing `WP_Theme_JSON` object from raw theme_json, instead
use `WP_Theme_JSON` object inside `WP_Theme_JSON_data`
--------------------------+--------------------------
 Reporter:  thekt12       |       Owner:  thekt12
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  6.6
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  performance
--------------------------+--------------------------

Comment (by thekt12):

 @ryelle `Call to undefined method
 WP_Theme_JSON_Data_Gutenberg::get_theme_json()` is a bit strange error to
 occur. If you see the introduction of
 `WP_Theme_JSON_Data_Gutenberg::get_theme_json()` method and related
 changes occur in a single
 PR([https://github.com/WordPress/gutenberg/pull/61262 PR]). Can you check
 if changes to `https://github.com/WordPress/gutenberg/blob/trunk/lib
 /class-wp-theme-json-data-gutenberg.php` are reflected properly on that
 site, I can see the method on trunk?

 Also, there is no fear of conflict with the core as class names are
 different in both places. If WP trunk + Gutenberg are active, the
 Gutenberg class is given priority over the core class.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61112#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list