[wp-trac] [WordPress Trac] #43: pingback_ping() is not using the check for prior pings
WordPress Trac
noreply at wordpress.org
Mon Mar 25 04:20:45 UTC 2024
#43: pingback_ping() is not using the check for prior pings
--------------------------+-----------------------
Reporter: unbrand | Owner: michel v
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: XML-RPC | Version:
Severity: minor | Resolution: fixed
Keywords: | Focuses:
--------------------------+-----------------------
Comment (by o44czp8oqy):
In the XML-RPC file, specifically within the pingback_ping() function
around line 1967, there's a supposed check intended to prevent duplicate
pingbacks from the same originating server for the same article. While
this seems like a sensible precaution, upon closer inspection, it appears
that the check is not effectively utilized. There's an if (1==1) condition
in place, essentially ensuring that the pingback insertion code is always
executed regardless of any prior pingbacks.
This design flaw impedes the ability to call pingback_ping() more than
once for the same article. In scenarios where it's necessary to parse a
post body multiple times to detect additional URIs for pinging, this
limitation becomes problematic. Ideally, we should be able to call
pingback_ping() multiple times for the same article to accommodate such
situations.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list