[wp-trac] [WordPress Trac] #39281: Twenty Seventeen: header.php forces thumbnails on all post types

[WordPress Trac]

#39281: Twenty Seventeen: header.php forces thumbnails on all post types
---------------------------+------------------------------
 Reporter:  justnorris     |       Owner:  (none)
     Type:  enhancement    |      Status:  reopened
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:  4.8
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  ui, template
---------------------------+------------------------------

Comment (by poena):

 == Testing instructions
 Apply PR https://github.com/WordPress/wordpress-develop/pull/6157.
 Activate the theme
 Create two pages and a post with featured images.
 View the pages and post on the front.

 === Expected Results
 When testing a patch to validate it works as expected:
 - ✅ On the single post and the single page, the featured image hows.


 Assign one of the pages as the front page:
 Go to the WordPress admin, Settings, Reading, and change
 "Your homepage displays" to a static page, and select the page you just
 created.

 === Expected Results
 When testing a patch to validate it works as expected:
 - ✅ The theme header image and the page featured image shows **once**.


 To test the filter, add the following in functions.php after
 {{{twentyseventeen_should_show_featured_image()}}}, or in a child theme or
 plugin:
 {{{
 add_filter( 'twentyseventeen_should_show_featured_image', '__return_false'
 );
 }}}

 === Expected Results
 When testing a patch to validate it works as expected:
 - ✅ On the static front page with the page assigned, the theme header
 image and the page featured image should show **once**.
 - ✅ On the single post and the single page, the featured image should not
 show.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/39281#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform