[wp-trac] [WordPress Trac] #44588: Denote the Copy action is complete by updating the Copy button to state 'Copied'

WordPress Trac noreply at wordpress.org
Fri Jan 10 01:22:02 UTC 2020


#44588: Denote the Copy action is complete by updating the Copy button to state
'Copied'
-------------------------------------------------+-------------------------
 Reporter:  garrett-eclipse                      |       Owner:  garrett-
                                                 |  eclipse
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.4
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots needs-     |     Focuses:
  testing dev-feedback 2nd-opinion               |  administration
-------------------------------------------------+-------------------------

Comment (by nickylimjj):

 Hey @xkon!

 The initial patches (up to .3) that uses `data-clipboard-text` manage to
 exclude the `description` (refer to clipboard-data.png) because the first
 parameter in `self::get_default_content( false, false )` can control that.
 I considered `data-clipboard-target` but I had the same problem you
 encountered in your .4 patch + it left a side effect on my browser (the
 text was highlighted, as if you dragged your cursor across).

 Perhaps we would want to redefine the`$section['policy_text']` data
 structure for more effective targeting? Otherwise, another strategy could
 be to create a function that parses `$section['policy_text']` since it's
 already expressive as HTML.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44588#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list