[wp-trac] [WordPress Trac] #47720: Walker_Nav_Menu filter nav_menu_link_attributes checks $atts argument via empty() and not isset(), causing confusion with legitimate values that evaluate to boolean false

[WordPress Trac]

#47720: Walker_Nav_Menu filter nav_menu_link_attributes checks $atts argument via
empty() and not isset(), causing confusion with legitimate values that
evaluate to boolean false
-------------------------------------+-----------------------------
 Reporter:  nevma                    |       Owner:  SergeyBiryukov
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  5.3
Component:  Menus                    |     Version:  5.2.2
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch needs-testing  |     Focuses:  template
-------------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"46413" 46413]:
 {{{
 #!CommitTicketReference repository="" revision="46413"
 Menus: In `Walker_Nav_Menu`, `Walker_Category`, and `Walker_Page`,
 properly output link attributes having a legitimate "empty" value, for
 example an HTML data attribute with a value of zero (0).

 Props nevma, AkSDvP, greenshady, SergeyBiryukov.
 Fixes #47720.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47720#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform