[wp-trac] [WordPress Trac] #47720: Walker_Nav_Menu filter nav_menu_link_attributes checks $atts argument via empty() and not isset(), causing confusion with legitimate values that evaluate to boolean false

WordPress Trac noreply at wordpress.org
Thu Oct 3 22:11:26 UTC 2019


#47720: Walker_Nav_Menu filter nav_menu_link_attributes checks $atts argument via
empty() and not isset(), causing confusion with legitimate values that
evaluate to boolean false
-------------------------------------+-----------------------------
 Reporter:  nevma                    |       Owner:  SergeyBiryukov
     Type:  defect (bug)             |      Status:  reviewing
 Priority:  normal                   |   Milestone:  5.3
Component:  Menus                    |     Version:  5.2.2
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  template
-------------------------------------+-----------------------------

Comment (by davidbaumwald):

 @SergeyBiryukov Is this still realistic for 5.3?  If not, feel free to
 move to `Future Release` or `5.4` based on your preference.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47720#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list