[wp-trac] [WordPress Trac] #17184: Press This Bookmarklet Redesign
WordPress Trac
wp-trac at lists.automattic.com
Mon Jun 6 04:04:26 UTC 2011
#17184: Press This Bookmarklet Redesign
-------------------------------------+-----------------------
Reporter: chexee | Owner: Chexee
Type: enhancement | Status: reopened
Priority: low | Milestone: 3.2
Component: UI | Version: 3.1
Severity: trivial | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+-----------------------
Changes (by johnjamesjacoby):
* status: closed => reopened
* resolution: fixed =>
Comment:
The behavior of the "Press This" link is still a little off, particularly
in Chrome. I wouldn't normally re-open a closed ticket this late, but I
think in this case it warrants another look-see.
So the description says:
{{{
Drag-and-drop the following link to your bookmarks bar or right click it
and add it to your favorites for a posting shortcut.
}}}
...yet when I right-click in Chrome, it either highlights the text in the
span (because I right-clicked the span) or returns false and acts like I
right-clicked the body (because it's returning false on-click. There's
effectively no URL to add to the bookmarks bar.
Further more, if I opted to hide the bookmarks-bar in Chrome I have no
where to drag the link to. If I drag it to the tab-bar, it opens a new
empty tab which immediately pops open the JS window, without ever giving
me the chance to bookmark it.
I'm attaching a patch (which is by no means elegant) that puts the URL
string in a prompt() that appears onclick. This needs core-dev and UX
feedback. Even if my solution isn't the end-all, I think this might need
more attention.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/17184#comment:16>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list