[wp-hackers] Any chance of the "Kubrick vs hReview" patch being
accepted prior to WP 2.0 release?
pp at myelin.co.nz
Tue Dec 20 03:41:14 GMT 2005
Sure - done.
This isn't quite as "nice" as ryansking's original patch, but it still
solves the hreview problem.
BTW, I've also been talking to David Janes about getting hAtom
(http://microformats.org/wiki/hatom) support into WP 2.0. This would
require renaming the "entry" and "content" classes in Kubrick, as hAtom
uses "entry" to wrap a post, and "content" to wrap the post
content/description. I can do a patch for this if this is an acceptable
sort of change...?
As with the above patch, this would of course change Kubrick so people
with modified stylesheets wouldn't be able to use them with the new
themes/default/*, but then, people doing that have hopefully made a copy
of themes/default in which to make their changes...
Aaron Brazell wrote:
> Why not create a patch for the template file itself to use a different
> class than "description" and submit it instead with an explanation of
> why the patch is important? It seems like a valid point, not so much
> for the core of WP, but for a fairly mild accommodation of the
> microformat? The only real impact I would see is for users who have
> tweaked Kubrick with additional CSS/markup and don't want to have that
> stylesheet overwritten with a new style and template. But they would
> run that risk anyway if they don't change the theme name/folder as a
> new release would overwrite existing changes.
> > I'm not sure what the proper protocol for this is, but there's a
> > I'd like to enourage someone to look at. It modifies the
> stylesheet for
> > the default WP template so that it doesn't conflict with the
> > microformat:
> > http://trac.wordpress.org/ticket/1436
> > Short summary of why this is worthwhile: hReview requires that
> you mark
> > up the description area with the 'description' class. Kubrick uses
> > 'description' to style the blog subtitle. This results in review
> > contents in a Kubrick-using WP blog appearing in white text on a
> > background.
> > I hacked around this for the SB plugin by inserting some
> > the footer that would strip the 'description' class off anything not
> > inside the header. This patch would let hReview work if you
> don't have
> > the SB plugin installed.
More information about the wp-hackers