[buddypress-trac] [BuddyPress Trac] #9145: Move the BP REST API into BuddyPress core
buddypress-trac
noreply at wordpress.org
Sat May 4 12:34:57 UTC 2024
#9145: Move the BP REST API into BuddyPress core
-------------------------+-----------------------------
Reporter: espellcaste | Owner: espellcaste
Type: task | Status: assigned
Priority: normal | Milestone: Awaiting Review
Component: REST API | Version:
Severity: normal | Keywords:
-------------------------+-----------------------------
Custom REST API endpoints from BuddyPress are handled into a separate
Github repo: https://github.com/buddypress/BP-REST/
This means that any REST API code is first worked on there, and we bundle
it with BP core when releasing a version.
This creates an odd behavior for code development. The need to set up
another project locally. And it might create some issues too for testing.
[https://github.com/buddypress/BP-REST/pull/501 See this for a recent
example.]
That repo was very useful to me (I'm the one that advocated for it in the
past) when I started to contribute to it since I was not very ''savant''
with SVN. However, that changed and I think we should consider and discuss
if we should retire this project and bring everything in house.
Some of my reasons are:
- no need to maintain Github Actions in another project
- no need for tickets and github issues
- if you svn buddypress, you get BP REST API too
- ^ no need to setup another project
- any phpcs rule we apply to core, it is reflected in the BP REST API
(since they'll be in the same codebase)
- any improvements in the running of the unit tests, BP REST benefits See
#9081
We need to consider:
- Unit tests
- Remove deployment integration
- Loading of files
- Is there any benefit in keeping the separate repo now?
There is no rush to make this move. But I'd like to start a conversation
about it. :)
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/9145>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list