[buddypress-trac] [BuddyPress Trac] #1475: bp_get_total_unread_messages_count()

[buddypress-trac]

#1475: bp_get_total_unread_messages_count()
-------------------------------------------------+-------------------------
 Reporter:  _DorsVenabili                        |       Owner:
                                                 |  espellcaste
     Type:  enhancement                          |      Status:  assigned
 Priority:  trivial                              |   Milestone:  Up Next
Component:  Messages                             |     Version:
 Severity:  trivial                              |  Resolution:
 Keywords:  good-first-bug needs-patch 2nd-      |
  opinion                                        |
-------------------------------------------------+-------------------------
Changes (by espellcaste):

 * keywords:  good-first-bug => good-first-bug needs-patch 2nd-opinion


Comment:

 I might have an unpopular opinion about this request. I'd suggest NOT
 doing this. Here is why:

 1 - The ticket does not have enough information to help me decide how
 useful this would be or what problem is solving;

 2 - If you want to get the admin notices, you can use
 `BP_Messages_Notice::get_total_notice_count()`, here I can see us
 improving this function since it doesn't seem to be getting only active
 notices, but all notices;

 3 - `bp_get_total_unread_messages_count` and
 `BP_Messages_Notice::get_total_notice_count()` serve different types of
 messages, so I don't think they should be bundled together by the use of a
 `param`/`variable`.


 I do think that we could introduce something like
 `bp_get_total_unread_notices_count`, to get the total count of the current
 unread admin notices (assuming several can be created at the same time,
 which I think that's not currently possible or offered out of the box),
 which I'm guessing is what @_DorsVenabili is looking for.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/1475#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac