[buddypress-trac] [BuddyPress Trac] #8556: BP_Notifications_Notification::get - error for meta_query

[buddypress-trac]

#8556: BP_Notifications_Notification::get    - error for meta_query
-------------------------------------------------+-------------------------
 Reporter:  shawfactor                           |       Owner:
                                                 |  espellcaste
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  Up Next
Component:  Toolbar & Notifications              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  needs-testing has-patch has-unit-    |
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by espellcaste):

 > actually fixing this also requires patching the method get_where_sql in
 the same class to ensure that the id field is never ambiguous when you do
 a join with the meta table.

 @shawfactor I found that not to be the case. After adding `n.*`, we don't
 get duplicate column ids anymore, so I haven't seen anything to patch
 related to this feedback.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8556#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac