[buddypress-trac] [BuddyPress Trac] #8581: Extending no content activities with images and call of actions

[buddypress-trac]

#8581: Extending no content activities with images and call of actions
----------------------------------------+---------------------
 Reporter:  vapvarun                    |       Owner:  (none)
     Type:  feature request             |      Status:  new
 Priority:  normal                      |   Milestone:  10.0.0
Component:  Activity                    |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  dev-feedback needs-refresh  |
----------------------------------------+---------------------
Changes (by imath):

 * keywords:  needs-patch dev-feedback => dev-feedback needs-refresh


Comment:

 Hi @vapvarun

 First thanks a lot for your initial patch. I can read from it you put a
 lot of energy into it. I already saw some possible improvements, but first
 I'm going to test and play a bit with it.

 Second, thanks a lot @oztaser for alerting us about the base64 db overheat
 warning! My initial thought was: I absolutely wanted to avoid creating a
 WordPress Attachments to store the images. Because:
 1. in this case it can be deleted outside of the activity and we have a
 risk of an error due to a vanished image
 2. we shouldn't use WordPress attachments for community members generated
 media imho.

 So the base64 is a bad idea, I'll try to think about it to suggest an
 alternative, as I've been playing with revisions on the BP Attachments
 feature as a plugin (I really need to find time to progress on it!!) & I
 have something in mind :)

 Finally looking at the patch, we might be too ambitious about it. I saw
 you were creating new activity actions @vapvarun, I believe we should
 focus on existing ones first, make sure we have something robust and then
 create the new ones.

 Important things about the feature are:
 a. avoid generating too much activity when the user is changing his
 profile image many times in a short amount of time because, he's not happy
 with the ones he chose...
 b. show the version of the avatar when the activity was created.

 Let's try to work on a. and b. :)

 @oztaser could you look at a. 🙏. I think it's already in BP Core, the
 goal is too only keep the latest activity about a profile image change.
 The idea is, before saving a new activity having the `'new_avatar'` type
 check if the user already created one of this type like in less than an
 hour ago and if so delete this activity and then publish the new activity.

 I'll look at b. 👌

 @vapvarun could you narrow the patch to existing no-content activities
 only ?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8581#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac