[buddypress-trac] [BuddyPress Trac] #8444: BP_Invitation: Increment date_modified on key actions.

[buddypress-trac]

#8444: BP_Invitation: Increment date_modified on key actions.
-------------------------+-----------------------
 Reporter:  dcavins      |       Owner:  (none)
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  8.0.0
Component:  Core         |     Version:  7.2.0
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+-----------------------

Comment (by dcavins):

 Hi @imath,

 Thanks for taking the time to look at this patch. I hope you didn't have
 trouble applying it, though I'm guessing you did because you attached a
 patch that looks the same except for line numbers. :)

 Regarding your questions:
 1) I used the original, passed args so that a `date_modified` would only
 be included when the `date_modified` was explicitly passed, rather than
 the parsed default value. I guess the difference isn't meaningful--if we
 were to pass `$r` along, then the sent time would be the same as if no
 `date_modified` were passed at all (you'd end up with
 `bp_core_current_time()` in both cases). So, I was trying to maintain the
 dev's intent, but it comes out in the wash; using the parsed args seems
 more consistent.
 2) Sure. Should I only include the arguments that currently have an effect
 (`date_modified`)?
 3) This is the same as 1 above.
 4) Yes that was a typo (I intended to use `passed_args` but didn't), but
 the answer to the first question applies here.

 Ha, really the vast majority of this code was added to make sure that our
 invitation pagination tests would pass (they require you to set the
 `date_modified` to work reliably because of the too-many-operations-
 happen-in-second problem). But setting those dates, while useful, is
 probably not common.

 Thanks again for your thoughts! It's simpler to think about it the way you
 suggest.

 -David

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8444#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac