[buddypress-trac] [BuddyPress Trac] #8444: BP_Invitation: Increment date_modified on key actions.

[buddypress-trac]

#8444: BP_Invitation: Increment date_modified on key actions.
-------------------------+-----------------------
 Reporter:  dcavins      |       Owner:  (none)
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  8.0.0
Component:  Core         |     Version:  7.2.0
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+-----------------------

Comment (by imath):

 Hi @dcavins

 I've just tested the patch, using the unit tests. It seems fine. Thanks a
 lot for your work on this.

 Some questions/advices ☺️

 1. At line 142 of `src/bp-core/classes/class-bp-invitation-manager.php`
 why aren't you using the `$r` parsed arguments instead of the `$args`
 unparsed ones? I'd expect something like: `$sent =
 $this->send_invitation_by_id( $invite_id, $r );`
 2. Could you describe the arguments of the array in the docblock of
 `BP_Invitation_Manager->send_invitation_by_id()` and in
 `BP_Invitation_Manager->send_request_notification_by_id()` ?
 ([https://developer.wordpress.org/coding-standards/inline-documentation-
 standards/php/#1-1-parameters-that-are-arrays WP documentation standards
 for arrays])
 3. About lines 492 & 538 of `src/bp-core/classes/class-bp-invitation-
 manager.php` why can't we just use `$this->mark_accepted( $r )` the
 modified date should be in it as `$r` is a parsed version of `$args` ?
 4. In `src/bp-core/classes/class-bp-invitation.php` the
 BP_Invitation::mark_accepted_by_data is not using the second argument,
 maybe we can get rid of it and do the same for
 `BP_Invitation_Manager->mark_accepted()` in `src/bp-core/classes/class-bp-
 invitation-manager.php` ?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8444#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac