[buddypress-trac] [BuddyPress Trac] #8540: Add caching and other enhancements to BP_Signup class.

[buddypress-trac]

#8540: Add caching and other enhancements to BP_Signup class.
------------------------------------+-----------------------
 Reporter:  dcavins                 |       Owner:  dcavins
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  10.0.0
Component:  Members                 |     Version:  9.0.0
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-reviewed  |
------------------------------------+-----------------------

Comment (by dcavins):

 Thanks for the review @imath!

 The reason for my change to the calculation of the `sent_date` when it is
 not set is that in the current situation it makes sense to assume the
 activation was sent at registration time (though we don't record it).
 However, in the case of the new signup being a *site membership request*,
 it's important to know that the activation mail was not yet sent. I'm
 thinking that a data update task when BP10 is installed will be to
 explicitly set the `sent_date` and `count_sent` for existing signups so
 that we can discern between old signups where we assume the date and
 number of times sent, and new requests that have never been sent. (A
 problem with that will be that that data is stored in a serialized array,
 so I believe we'll have to loop over each BP_Signup in php, ugh.)

 In any case, we can apply your logic now, and I'll change it as needed for
 requests to work. Thanks!

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8540#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac