[buddypress-trac] [BuddyPress Trac] #8540: Add caching and other enhancements to BP_Signup class.

[buddypress-trac]

#8540: Add caching and other enhancements to BP_Signup class.
------------------------------------+-----------------------
 Reporter:  dcavins                 |       Owner:  dcavins
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  10.0.0
Component:  Members                 |     Version:  9.0.0
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-reviewed  |
------------------------------------+-----------------------
Changes (by imath):

 * keywords:  has-patch dev-feedback => has-patch dev-reviewed


Comment:

 Hi @dcavins

 Thanks again for your work on these improvements and sorry about my late
 review about them.

 I've tested `8540.1.patch`. I believe there's an issue with the way the
 `sent_date` is set.
 See the screenshot below:

 [[Image(https://cldup.com/LDBQmonqWv.png)]]

 I believe when the `sent_date` is not set or equals to '0000-00-00
 00:00:00', it should be set with the registered date of the signup. I've
 included this suggestion and some WP PHP Code standards ones into
 `8540.1.suggestions.patch`.

 After applying `8540-change-active-handling.patch`, I get a failing test:
 {{{
 1) BP_Tests_BP_Signup::test_objects_should_be_cached
 Failed asserting that 48 matches expected 0.

 /buddypress/tests/phpunit/testcases/members/class-bp-signup.php:550
 }}}

 In `8540-change-active-handling.suggestions.patch` you'll find some other
 formatting suggestions 😉.

 Finally I confirm I can register, activate, and that the admin can see,
 resend, activate and delete the new signup into the Manage Signups screen.
 I also confirm an already activated account trying to use the activation
 key again into the activation screen get the error message you shared into
 your screenshot 👍

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/8540#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac