[buddypress-trac] [BuddyPress Trac] #7130: bp_notifications_get_all_notifications_for_user gets all records and can cause memory leak

buddypress-trac noreply at wordpress.org
Mon Mar 5 12:57:25 UTC 2018


#7130: bp_notifications_get_all_notifications_for_user gets all records and can
cause memory leak
-------------------------------------+---------------------------
 Reporter:  hberberoglu              |       Owner:  boonebgorges
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  3.0
Component:  Toolbar & Notifications  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch                |
-------------------------------------+---------------------------

Comment (by boonebgorges):

 In [changeset:"11888"]:
 {{{
 #!CommitTicketReference repository="" revision="11888"
 Move notification-grouping logic to MySQL.

 The notification-grouping logic required to show the collapsed
 Notifications
 toolbar - "You have 3 pending friend requests", etc - is currently done in
 PHP, in a manner that requires all notifications to be loaded into memory
 and processed. On sites where users have large numbers of notifications,
 this
 operation requires extensive resources. By leaving the grouping to MySQL,
 we can speed up processing in almost all situations.

 This changeset also adds specific caching for grouped notifications.

 Props m_uysl.
 See #7130.
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7130#comment:22>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list