[buddypress-trac] [BuddyPress Trac] #7436: Very slow check_is_friend function
buddypress-trac
noreply at wordpress.org
Fri Feb 23 19:44:55 UTC 2018
#7436: Very slow check_is_friend function
--------------------------+------------------
Reporter: januzi_pl | Owner:
Type: defect (bug) | Status: new
Priority: high | Milestone: 3.0
Component: Friends | Version: 2.7
Severity: major | Resolution:
Keywords: dev-feedback |
--------------------------+------------------
Comment (by r-a-y):
Looks good, @dcavins.
My only minor thing is with the naming of the `warm_friendship_cache()`
method. WordPress uses the term `lazyload`. See the `WP_Query` class for
an example. I'm just nitpicking! Feel free to ignore.
We should also change the PHPDoc for the `$ids` parameter in
`bp_core_set_incremented_cache()`:
https://buddypress.trac.wordpress.org/browser/trunk/src/bp-core/bp-core-
cache.php?marks=301,306#L286
In this patch, the use-case here for `$ids` is a string. We should also
probably change the `$ids` name to `$value`.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7436#comment:20>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list