[buddypress-trac] [BuddyPress Trac] #7436: Very slow check_is_friend function

buddypress-trac noreply at wordpress.org
Fri Feb 23 03:49:55 UTC 2018


#7436: Very slow check_is_friend function
--------------------------+------------------
 Reporter:  januzi_pl     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  3.0
Component:  Friends       |     Version:  2.7
 Severity:  major         |  Resolution:
 Keywords:  dev-feedback  |
--------------------------+------------------
Changes (by boonebgorges):

 * milestone:  Awaiting Contributions => 3.0


Comment:

 @dcavins Thank you for your work on this. The strategy here looks like the
 right one.

 > Finally, this change doesn't replace the user-specific friendship cache
 as introduced in 2.5. I think there's still value to having that cached,
 since it is used in friendship calls that refer to all friendships for a
 user.

 Yes, I think that's a sensible approach. I do think there's room to
 improve that system in ways [comment:16 I mentioned above], but for the
 purposes of `check_is_friend()`, your proposed changes in this ticket
 allow us to kick that question down the road.

 If anyone on this ticket runs a site with users with lots of friends and
 is able to run some tests, it'd be helpful. Otherwise, I'm happy with the
 approach - though another look from @r-a-y would be welcome too.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7436#comment:19>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list