[buddypress-trac] [BuddyPress Trac] #7442: Use JOIN rather than Subquery on user search

buddypress-trac noreply at wordpress.org
Wed Feb 7 19:13:48 UTC 2018


#7442: Use JOIN rather than Subquery on user search
------------------------------------------+------------------
 Reporter:  brandonliles                  |       Owner:
     Type:  enhancement                   |      Status:  new
 Priority:  normal                        |   Milestone:  3.0
Component:  Core                          |     Version:
 Severity:  normal                        |  Resolution:
 Keywords:  has-patch dev-feedback early  |
------------------------------------------+------------------

Comment (by boonebgorges):

 No, caching is not a blocker.

 > It seems to me at a glance that we'd have to clear said cache every time
 the users table is written to -- which we can't do, when that table is
 running as a WP global table.

 The general strategy here in WP is to hash the cache key with an
 incrementor, and then to expire caches by bumping the incrementor, which
 would happen on events like `wp_insert_user()` and `wp_update_user()`.
 But, while WP already does this for term and comment queries, and for some
 post queries, it doesn't have a `last_changed` incrementor for 'users'.
 See https://core.trac.wordpress.org/ticket/40613. I don't see a strong
 argument that BP should be handling this, so I agree that caching is not
 feasible at the moment.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7442#comment:12>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list