[buddypress-trac] [BuddyPress Trac] #7442: Use JOIN rather than Subquery on user search
buddypress-trac
noreply at wordpress.org
Wed Feb 7 11:36:16 UTC 2018
#7442: Use JOIN rather than Subquery on user search
------------------------------------------+------------------
Reporter: brandonliles | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.0
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch dev-feedback early |
------------------------------------------+------------------
Comment (by DJPaul):
Before I move this out the 3.0 milestone for inactivity, this path
actually looks pretty close, and there's previous agreement from two of
the team. It is very unfortunate there are no benchmarks, but if this is
meant to be an improvement, we can add it to 3.0 but will be unable to any
kind of performance number for the specific improvement.
As far as the patch looks, we need to wrap the new query parts in
`$wpdb->prepare()`, I think.
@boonebgorges Is the new query not being cached a blocker? If so, how long
should it be cached for, and when should the cache be cleared? It seems to
me at a glance that we'd have to clear said cache every time the users
table is written to (which we can't do, when that table is running as a WP
global table).
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7442#comment:11>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list