[buddypress-trac] [BuddyPress Trac] #6014: Include BP Edit Group Slug into the core

buddypress-trac noreply at wordpress.org
Thu Mar 30 19:36:36 UTC 2017

#6014: Include BP Edit Group Slug into the core
 Reporter:  slaFFik      |       Owner:  dcavins
     Type:  enhancement  |      Status:  accepted
 Priority:  normal       |   Milestone:  Future Release
Component:  Groups       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  needs-patch  |

Comment (by dcavins):

 Replying to [comment:13 boonebgorges]:
 Thanks for taking a look at this patch! I agree with everything you've

 > What's the advantage of breaking this into a hooked function? So that it
 can be disabled? It feels like it'd be more natural in our "routing"
 logic, inside `BP_Groups_Component::setup_globals()`. It also feels icky
 to be modifying global variables outside of our component classes, since
 it can be very unpleasant to debug.
 Yes, I added it via hook primarily so that someone could unhook it. (I'm
 not sure why you wouldn't want that behavior though.) I first built it in
 into `BP_Groups_Component::setup_globals()` but thought I was being
 presumptuous. If it's OK with everyone else, I'd rather put it with the
 rest of the routing logic, too.

 > If we need `orderby=meta_id` in group queries, we should add it there
 rather than implementing by filter. (When you asked me about this earlier,
 I didn't know it was for a BP patch :) )
 Ha ha. Yes, I have another patch where I add that orderby option to
 `get()`. Again, it seemed so specific to my problem that I was afraid it
 wouldn't generally be of interest.

 Thanks for the encouragement to move these changes into the foundational
 places they belong. I'll update the patch. :)

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6014#comment:14>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list