[buddypress-trac] [BuddyPress Trac] #6014: Include BP Edit Group Slug into the core

buddypress-trac noreply at wordpress.org
Thu Mar 30 19:28:35 UTC 2017

#6014: Include BP Edit Group Slug into the core
 Reporter:  slaFFik      |       Owner:  dcavins
     Type:  enhancement  |      Status:  accepted
 Priority:  normal       |   Milestone:  Future Release
Component:  Groups       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  needs-patch  |

Comment (by boonebgorges):

 Thanks for working on this, @dcavins! The basic strategy sounds good to

 A check like `groups_get_id()`, which will take place on every pageload,
 should be done carefully. I know you're looking to cache it #7477, but I
 wonder why it's necessary at all. The check already takes place here
 groups/classes/class-bp-groups-component.php#L198. Can't we just check for

 What's the advantage of breaking this into a hooked function? So that it
 can be disabled? It feels like it'd be more natural in our "routing"
 logic, inside `BP_Groups_Component::setup_globals()`. It also feels icky
 to be modifying global variables outside of our component classes, since
 it can be very unpleasant to debug.

 If we need `orderby=meta_id` in group queries, we should add it there
 rather than implementing by filter. (When you asked me about this earlier,
 I didn't know it was for a BP patch :) )

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6014#comment:13>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list