[buddypress-trac] [BuddyPress Trac] #7642: Nouveau: re-factor bp_nouveau_signup_form() bp field error messages handling

buddypress-trac noreply at wordpress.org
Tue Dec 12 14:41:38 UTC 2017


#7642: Nouveau: re-factor bp_nouveau_signup_form() bp field error messages
handling
------------------------------------+---------------------
 Reporter:  hnla                    |       Owner:  hnla
     Type:  task                    |      Status:  closed
 Priority:  normal                  |   Milestone:  3.0
Component:  Templates               |     Version:
 Severity:  normal                  |  Resolution:  fixed
 Keywords:  has-patch dev-feedback  |
------------------------------------+---------------------
Changes (by hnla):

 * owner:   => hnla
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"11770"]:
 {{{
 #!CommitTicketReference repository="" revision="11770"
 Nouveau: re-factor bp_nouveau_signup_form error handling

 Commit:
  1. Re-factors the signup template for new class token rendering & error
 checking & display of BP signup errors.
  2. Adds new function to provide html template markup for error string
 rendering.

 Previously the signup form function rendered the BP global signup->errors
 via the BP action/do_action, proving hard to style messages in keeping
 with other site messages.

 Commit builds a new function to pass the BP global
 `buddypress()->signup->errors[ $name ]` to, rendering the message string
 in suitable html. This function may be re-used for any additional in page
 error messages falling outside the Nouveau feedback message array.

 Additionally no means of easily identifying the error fields existed, they
 would display as per browser 'required=required' styling. If BP global
 errors are set in each loop pass we generate a class 'invalid' to use to
 style the input on and that matches to the HTML5 pseudo class.

 Props hnla, DJPaul, boonebgorges

 Fixes #7642
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7642#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list