[buddypress-trac] [BuddyPress Trac] #3961: Hierarchical groups
buddypress-trac
noreply at wordpress.org
Fri Sep 9 20:38:03 UTC 2016
#3961: Hierarchical groups
------------------------------------+-----------------------
Reporter: sooskriszta | Owner: dcavins
Type: enhancement | Status: assigned
Priority: normal | Milestone: 2.7
Component: Groups | Version:
Severity: normal | Resolution:
Keywords: dev-feedback has-patch |
------------------------------------+-----------------------
Comment (by boonebgorges):
A couple notes:
- The `if ( ! empty( $r['parent_id'] ) ) { ` check in
`BP_Groups_Group::get()` will make it impossible to fetch groups with
parent=0. This should be a stricter check of some sort. I suggest making
the default value `null` or `false`, and then changing the check here to
`if ( null !== $r['parent_id'] )`. Tests demonstrating this behavior would
also be excellent.
- It would be nice to have `@since` documentation where new params are
added to existing functions.
- There seems to be an indentation issue in `bp_update_to_2_7()`
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3961#comment:56>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list