[buddypress-trac] [BuddyPress Trac] #6534: A new API to manage single items navigation

[buddypress-trac]

#6534: A new API to manage single items navigation
-------------------------+---------------------------
 Reporter:  imath        |       Owner:  boonebgorges
     Type:  enhancement  |      Status:  reopened
 Priority:  high         |   Milestone:  2.6
Component:  API - Nav    |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+---------------------------
Changes (by boonebgorges):

 * keywords:  dev-feedback has-patch => has-patch


Comment:

 Thanks, @imath and @dcavins. My takeaway from the above is that the only
 real bug is in `bp_core_remove_subnav_item()`. But if we're going to
 change that logic to set `$component = 'groups'`, then we may as well
 change it in both places.

 > That's probably the reason why you added this backward compat block in
 the first place.

 Calling `bp_core_remove_nav_item( 'foo' )`, where 'foo' is a group slug,
 will pretty much completely break your site. This is true both in 2.5 and
 in 2.5. I guess it makes sense to carry over this 2.5 behavior, though I
 think it doesn't matter much. I don't recall why I added that block - I
 have a feeling it was either copypasta, or it was something that @imath
 added in an original patch - but I guess it's fine to keep it.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6534#comment:45>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac