[buddypress-trac] [BuddyPress Trac] #6844: Extract & relocate core markup functions: Theme compat include functionality & search forms file

[buddypress-trac]

#6844: Extract & relocate core markup functions:  Theme compat include
functionality & search forms file
-----------------------------------------+------------------------------
 Reporter:  hnla                         |       Owner:
     Type:  enhancement                  |      Status:  new
 Priority:  normal                       |   Milestone:  Awaiting Review
Component:  Appearance - Template Parts  |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch dev-feedback       |
-----------------------------------------+------------------------------

Comment (by boonebgorges):

 Thanks for seeing this through, @hnla. The general approach looks pretty
 good to me.

 For brevity, I chose to use the same template tag for the 'name' and 'id'
 attributes. I also opted to concatenate the submit button name/id ("`<?php
 bp_search_input_name(); ?>_submit`"). Are you OK with these choices?

 It'd be nice to get feedback from another core dev on the approach -
 moving markup out of filtered files and into template parts shared between
 components - before moving any further. I assume @johnjamesjacoby likes it
 as it's what bbPress does, but it would be nice to hear from @djpaul or
 @r-a-y or @imath.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6844#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac