[buddypress-trac] [BuddyPress Trac] #6592: Email API and customisation features
buddypress-trac
noreply at wordpress.org
Tue Jan 26 03:20:40 UTC 2016
#6592: Email API and customisation features
------------------------------+-----------------------
Reporter: DJPaul | Owner: DJPaul
Type: idea | Status: assigned
Priority: normal | Milestone: 2.5
Component: Component - Core | Version:
Severity: normal | Resolution:
Keywords: |
------------------------------+-----------------------
Comment (by boonebgorges):
The changes described in [comment:47] all look great to me. (I suggested
them, so no big surprise :) )
Replying to [comment:48 DJPaul]:
> Core team: I would like feedback on
https://buddypress.trac.wordpress.org/ticket/6592#comment:45 -- either we
bump requirement to WP 4.0 (please) or somehow re-implement `add_panel`. ?
> another scenario would be to do like @r-a-y did for embeds or like i
did for the Avatar UI, check for 4.0 and enable the BP Email feature only
if the required version for this feature match.
This seems silly, given that Customizer integration is only a small aspect
of DJPaul's patch.
If it were the beginning of the dev cycle, I'd say forget it, and bump to
4.0. Given that we already made the announcement, and go to beta in less
than 2 weeks, I feel like we should stick to our guns with 3.9. I suggest
silently dropping Customizer support in 3.9:
{{{
if ( ! method_exists( $wp_customizer, 'add_panel' ) ) {
return;
}
}}}
The Customizer stuff is great, but the rest of the feature works
beautifully without it, so I think we can degrade gracefully here. Also,
the chances of someone running BP 2.5 on WP 3.9 and wanting to customize
the appearance of their emails is practically nil, so I doubt anyone on
3.9 will notice :)
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6592#comment:50>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list