[buddypress-trac] [BuddyPress Trac] #6896: Improve BP Emails templating

[buddypress-trac]

#6896: Improve BP Emails templating
-----------------------------------------+------------------
 Reporter:  imath                        |       Owner:
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  2.5
Component:  Appearance - Template Parts  |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch                    |
-----------------------------------------+------------------

Comment (by imath):

 > Yes, theme templates normally work like this. ;)
 > Are you doing this JUST to filter it?

 1) Absolutely, imho it seems really a huge task to:
 - register a new template dir
 - make sure this template dir will only be added to the stack if the email
 template is required to avoid adding 3 new entries in the stack each time
 `bp_get_template_part()` is used
 - do a copy paste of the single email template inside the plugin's
 template dir

 *JUST* to add a logo before the site name, while a filter would avoid all
 this :)

 2) All other template parts are using template tags including filters, so
 it's a bit weird to not have the same possibility for this particular
 template.

 I agree, Themes can add their template, and plugins can also do that like
 i've described in point 1. So i really don't mind not having template tags
 there, although i see no good reason not to have them..

 But: the untranslated string should be fixed.

 > What happens right now if this isn't present?
 It's not broken, the page reload. But the css should be included to inform
 the user the page is reloading in case a setting using the refresh
 transport method  has been added by a plugin (like the plugin I've built
 is doing). To me, Not including the css means we haven't thought of
 supporting the refresh transport method for a customizer setting.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6896#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac