[buddypress-trac] [BuddyPress Trac] #7409: Action request: cover image deleted
buddypress-trac
noreply at wordpress.org
Wed Dec 28 19:52:43 UTC 2016
#7409: Action request: cover image deleted
--------------------------------------+--------------------
Reporter: jdgrimes | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.8
Component: Core | Version: 2.5.0
Severity: normal | Resolution:
Keywords: good-first-bug has-patch |
--------------------------------------+--------------------
Changes (by boonebgorges):
* keywords: good-first-bug has-patch 2nd-opinion => good-first-bug has-
patch
Comment:
I agree with @slaFFik that we should generally avoid dynamic action/filter
names, as they're harder to read and harder to document. The one time
they're really advantageous is when a hook might be fired very, very
frequently; in this case, it's better for performance to avoid invoking
extra callbacks. The case of deleting a cover image isn't one of these
instances.
That being said, if we already have a dynamic hook name for updating, we
should probably do the same thing for deletion, just for the sake of
consistency.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7409#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list