[buddypress-trac] [BuddyPress Trac] #7409: Action request: cover image deleted

[buddypress-trac]

#7409: Action request: cover image deleted
--------------------------------------------------+--------------------
 Reporter:  jdgrimes                              |       Owner:
     Type:  enhancement                           |      Status:  new
 Priority:  normal                                |   Milestone:  2.8
Component:  Core                                  |     Version:  2.5.0
 Severity:  normal                                |  Resolution:
 Keywords:  good-first-bug has-patch 2nd-opinion  |
--------------------------------------------------+--------------------
Changes (by slaFFik):

 * keywords:  good-first-bug has-patch => good-first-bug has-patch 2nd-
               opinion


Comment:

 As an idea.
 What about the difference in approaches:

 `do_action( "{$component}_cover_image_deleted", (int)
 $cover_image_data['item_id'] );`
 vs
 `do_action( "bp_component_cover_image_deleted", (int)
 $cover_image_data['item_id'], $component );`

 Personally I would go with the second one, as it will allow much easier
 targeting in a hook of all components that have cover image deleted.
 Currently in a patch by @jdgrimes we need to get the list of components,
 and among them those that are using cover images to be able to target ANY
 covers deletion. That's a lot of extra work where it's easy to make a
 mistake.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7409#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac