[buddypress-trac] [BuddyPress Trac] #7226: Update BP_buttons class to accept new arg param for $element_type
buddypress-trac
noreply at wordpress.org
Fri Aug 19 19:23:22 UTC 2016
#7226: Update BP_buttons class to accept new arg param for $element_type
-------------------------+------------------
Reporter: hnla | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.7
Component: Core | Version:
Severity: normal | Resolution:
Keywords: needs-patch |
-------------------------+------------------
Comment (by hnla):
Thought it best or even necessary to default to the anchor in order to not
disrupt existing sites as 'a' to 'button' is a huge change and easily a
breaking one. Think we have to make the change on new templates by passing
the param 'element_type' => 'button' or we have to have some means of
changing the new default for legacy using templates?.
Trying to fathom the best approach as Nouveau is using a series of custom
classes and functions finally running bp_get_button() so trying to see if
it's not easier to just lift BP_button and transpose to Nouveau although
even if is tackling at function /class core is preferable or should in
reality a bit of functionality like this not live in templates period -
''sorry thinking out loud''
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7226#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list