[buddypress-trac] [BuddyPress Trac] #7028: Use stylelint to lint SCSS & CSS replacing Ruby gem `scss_lint`
buddypress-trac
noreply at wordpress.org
Wed Apr 27 02:04:32 UTC 2016
#7028: Use stylelint to lint SCSS & CSS replacing Ruby gem `scss_lint`
---------------------------------------+-----------------------------
Reporter: netweb | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Future Release
Component: Tools - Build Process | Version: 2.3.0
Severity: normal | Resolution:
Keywords: needs-patch needs-refresh |
---------------------------------------+-----------------------------
Comment (by netweb):
Replying to [comment:2 DJPaul]:
> We don't need the changed CSS files in the patch, only the grunt file,
etc. Can you trim the patch down? But thank you for making it easy for us
to see what the file changes.
The CSS changes are indeed needed in the patch, they will, or should be
committed. The changes make BuddyPress' CSS adhere to WordPress CSS coding
standards, the new stylelint lint task checks these standards against the
CSS going forward.
> We'll also need to update the Travis-CI configuration because I'm pretty
sure we had to customise it to get the old approach working.
Yes, forgot about this, will include it in the next patch iteration.
> It looks like we can commit this as soon as you're happy with however
you choose to resolve those TODOs. I figure we're happy to take your
advice on this.
>
> Thanks @netweb!
:)
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7028#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list