[buddypress-trac] [BuddyPress Trac] #7028: Use stylelint to lint SCSS & CSS replacing Ruby gem `scss_lint`

[buddypress-trac]

#7028: Use stylelint to lint SCSS & CSS replacing Ruby gem `scss_lint`
---------------------------------------+-----------------------------
 Reporter:  netweb                     |       Owner:
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  Future Release
Component:  Tools - Build Process      |     Version:  2.3.0
 Severity:  normal                     |  Resolution:
 Keywords:  needs-patch needs-refresh  |
---------------------------------------+-----------------------------

Comment (by hnla):

 There may be a few things to consider before committing.
 We seem to induce new errors that passed before under scsslint.

 Why do those scss lint commands need to be in true css comment syntax as
 in a scss file that means they are compiled pointlessly to the real
 stylefile, with scsslint I used their rules but in  forward slash escapes
 '//'

 We need to be careful about placing restrictions on how coders use things
 like shorthand properties they can be an arcane process requiring nuanced
 use.


 `block-opening-brace-newline-after`
 `block-closing-brace-newline-before`

 no!
 If it means this:
 {{{
 selector {

  property: value;

 }
 }}}

 `at-rule-empty-line-before `

 Yes - think I probably have done this instinctively, if not it can only
 help legibility to have a clear line.

 `rule-nested-empty-line-before`

 Not sure what this one refers to, seems same as one above, but if this is
 this:

 {{{
 selector {

  nested {
   property: value;
  }
 }
 }}}

 We do have a rule presently to cover a newline but after a property/value
 pair in the parent. If we go straight in with a nested selector with
 parent having no properties lets do a newline ( probably guilty of not
 having done so previously ).

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7028#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac