[buddypress-trac] [BuddyPress Trac] #6608: Groups invite friends input control echoing checked attr
buddypress-trac
noreply at wordpress.org
Wed Sep 2 14:25:54 UTC 2015
#6608: Groups invite friends input control echoing checked attr
--------------------------------+------------------
Reporter: hnla | Owner:
Type: defect (bug) | Status: new
Priority: high | Milestone: 2.4
Component: Component - Groups | Version:
Severity: major | Resolution:
Keywords: has-patch |
--------------------------------+------------------
Comment (by DJPaul):
The second parameter of `checked()` defaults to `true`. We don't gain
anything by passing a string instead.
It looks like `checked( $checked, true, false )` is the best smallest
change to fix the issue this ticket covers.
RE: the `label` element you added in the patch and didn't mention: while
this part of code has a number of stylistic and standards issues that I
would probably change if I were writing this today, let's keep fixes and
improvements separate. :)
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6608#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list