[buddypress-trac] [BuddyPress Trac] #6608: Groups invite friends input control echoing checked attr

[buddypress-trac]

#6608: Groups invite friends input control echoing checked attr
--------------------------------+------------------
 Reporter:  hnla                |       Owner:
     Type:  defect (bug)        |      Status:  new
 Priority:  high                |   Milestone:  2.4
Component:  Component - Groups  |     Version:
 Severity:  major               |  Resolution:
 Keywords:  has-patch           |
--------------------------------+------------------
Description changed by DJPaul:

Old description:

> In trunk bp-groups-templates.php L: 4957 we are currently echoing the
> `checked()` function when selecting a name to invite `checked="checked"`
> checked() being an echo function!
>
> This is introduced by way of changes to using the checked() function
> rather than passing in a variable as before; in changeset #9939
>
> checked() takes two mandatory? args and a third optional $echo
> true/false we need to pass that third arg if using this function so patch
> re-writes the $checked variable to hold the name ID if in array or else
> empty it and updates checked to carry $checked against the inputs value
> and ads 'false' to prevent echoing.

New description:

 In trunk bp-groups-templates.php L: 4957 we are currently echoing the
 `checked()` function when selecting a name to invite `checked="checked"`
 checked() being an echo function!

 This is introduced by way of changes to using the checked() function
 rather than passing in a variable as before; in changeset r9939

 checked() takes two mandatory? args and a third optional $echo  true/false
 we need to pass that third arg if using this function so patch re-writes
 the $checked variable to hold the name ID if in array or else  empty it
 and updates checked to carry $checked against the inputs value and ads
 'false' to prevent echoing.

--

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6608#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac