[buddypress-trac] [BuddyPress Trac] #6669: Blank notifications when using the bp_notifications_get_notifications_for_user filter hook

[buddypress-trac]

#6669: Blank notifications when using the
bp_notifications_get_notifications_for_user filter hook
---------------------------------------+----------------------
 Reporter:  henry.wright               |       Owner:
     Type:  defect (bug)               |      Status:  closed
 Priority:  normal                     |   Milestone:
Component:  Component - Notifications  |     Version:
 Severity:  normal                     |  Resolution:  invalid
 Keywords:                             |
---------------------------------------+----------------------
Changes (by r-a-y):

 * status:  new => closed
 * version:  2.3.3 =>
 * resolution:   => invalid
 * milestone:  Awaiting Review =>


Comment:

 > Which approach of the two would you recommend?

 There is no wrong way of doing it.

 The bbPress method also works for registering, but I prefer the suggestion
 I recommended above.

 The reason why is I think the
 `'bp_notifications_get_notifications_for_user'` filter is a little too
 general because there are no component checks.

 If you use this filter, you can only do checks on the component action
 name.  So there is the potential for conflicts to occur if other plugins
 use the same component action name to record their notifications and if
 the plugin is using this filter to format their notifications.

 Going to close this as I do not think this is a bug, but feel free to
 continue replying if you have other questions.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6669#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac