[buddypress-trac] [BuddyPress Trac] #6669: Blank notifications when using the bp_notifications_get_notifications_for_user filter hook

[buddypress-trac]

#6669: Blank notifications when using the
bp_notifications_get_notifications_for_user filter hook
---------------------------------------+------------------------------
 Reporter:  henry.wright               |       Owner:
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  Awaiting Review
Component:  Component - Notifications  |     Version:  2.3.3
 Severity:  normal                     |  Resolution:
 Keywords:                             |
---------------------------------------+------------------------------
Changes (by henry.wright):

 * keywords:  reporter-feedback =>


Comment:

 > Is there a specific reason why you are using the
 ''bp_notifications_get_notifications_for_user'' filter?

 I was looking at how bbPress does it in version 2.5.8. See here:

 https://plugins.trac.wordpress.org/browser/bbpress/tags/2.5.8/includes/extend/buddypress/notifications.php#L41

 I think the {{{bbp_format_buddypress_notifications()}}} function will
 suffer from the same problems I came across because that doesn't return a
 value in cases where {{{'bbp_new_reply' !== $action}}}? But looking at
 trunk, that function now seems to have been rewritten to return a value
 (like you suggested above).

 Also, thanks for the advice you gave in your
 {{{my_register_custom_notifications()}}} function above, that looks a neat
 way of doing it. Which approach of the two would you recommend?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6669#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac